Rename 'deposit' to 'payout' in 'Overview' section modals #9623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 24, 2024
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +7 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
|
Screenshots from update business modal (too much trouble to replicate by changing some status here and there ) 
|
jessy-p
approved these changes
Oct 28, 2024
nagpai
added a commit
that referenced
this pull request
Nov 4, 2024
The PR is a part of a larger project renaming `deposit` to `payout` across the WooPayments plugin UI. Co-authored-by: Nagesh Pai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9578 , #9579
Changes proposed in this Pull Request
The PR renames all occurences of 'deposit' to 'payout' within the 'Overview' section. This is a part of a larger project to do this rename throughout the WooPayments codebase.
Testing instructions
showProgressiveOnboardingEligibilityModaltotrueon this line . You should then see a modal as below on the overview page:Overviewpage,Account detailssection, click the reset button. You should see the text changed topayoutsas below:UpdateBusinessDetailsModal. I have so far found it difficult to simulate the situation in which the modal gets shown.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge